ckochandClaude Opus 5
2a7d90b2d5
The 2018 stack (Angular 5.2 / CLI 1.7, PHP, MySQL) had not been touched since
July 2018. Rebuilt rather than upgraded in place: the frontend was 17 major
versions behind, and of ~16,700 lines of PHP only ~150 were application logic —
the rest was four near-identical vendored copies of php-crud-api plus
class.upload.php.
Backend — ASP.NET Core 10, EF Core, SQLite
* ASP.NET Core Identity (PBKDF2) + JWT bearer auth
* Clean REST API replacing php-crud-api's filter[]/transform query syntax
* Box art uploads re-encoded to WebP via SkiaSharp
* Imports the 105 games recovered from the 2018 dump on first run
Frontend — Angular 22, zoneless, signals, Material 22
* Standalone components, lazy routes, functional guards and interceptor
* Vitest replaces Karma/Jasmine; fonts and icons bundled, no CDN calls
* No provideAnimations: @angular/animations is deprecated in v22 and
Material no longer depends on it (pinned by a test)
Docker
* Multi-stage builds for both services, non-root at runtime
* nginx serves the SPA and reverse-proxies the API, so everything is
same-origin; one volume holds the database, uploads and DP keys
Security issues in the old code, not carried across:
* Two endpoints exposed unauthenticated CRUD over every table
* The client chose whose rows to read (filter[]=userId,eq,N); ownership now
comes from the JWT subject server-side
* Login was hardcoded to a single username
* crypt() with one global salt, silently truncating passwords to 8 chars
* JWT secret was the literal string "testing", tokens never expired
* Token travelled in the query string rather than a header
* Uploads were anonymous with the path built from the client filename
* Access-Control-Allow-Origin: *
The live MySQL password committed in 2018 remains in git history and must be
rotated independently of this change.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
27 lines
995 B
Docker
27 lines
995 B
Docker
# syntax=docker/dockerfile:1
|
|
|
|
# ---- build ----------------------------------------------------------------
|
|
# Pinned to the same Node major the project declares in package.json engines.
|
|
FROM node:24-alpine AS build
|
|
WORKDIR /app
|
|
|
|
# npm ci against the lockfile alone, so this layer caches across source edits.
|
|
COPY package.json package-lock.json ./
|
|
RUN npm ci
|
|
|
|
COPY . .
|
|
RUN npm run build:prod
|
|
|
|
# ---- runtime --------------------------------------------------------------
|
|
# Unprivileged nginx: listens on 8080 and runs as a non-root user out of the box.
|
|
FROM nginxinc/nginx-unprivileged:alpine AS runtime
|
|
|
|
COPY --chown=nginx:nginx nginx.conf /etc/nginx/conf.d/default.conf
|
|
COPY --chown=nginx:nginx security-headers.conf /etc/nginx/snippets/security-headers.conf
|
|
COPY --from=build --chown=nginx:nginx /app/dist/ludos-web/browser /usr/share/nginx/html
|
|
|
|
EXPOSE 8080
|
|
|
|
HEALTHCHECK --interval=30s --timeout=3s --start-period=5s --retries=3 \
|
|
CMD ["wget", "-q", "--spider", "http://127.0.0.1:8080/"]
|